Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

deps: update node-inspect to v2.0.0 #33447

Closed
wants to merge 1 commit into from
Closed

deps: update node-inspect to v2.0.0 #33447

wants to merge 1 commit into from

Conversation

jkrems
Copy link
Contributor

@jkrems jkrems commented May 17, 2020 •
edited
Loading

Highlights:

  • Remove use of process.binding on modern node (@addaleax)
  • Increase timeout for port checking (@yilmazdurmaz)
  • Auto-resume on start when NODE_INSPECT_RESUME_ON_START is set (@dolsem)

Compare: nodejs/node-inspect@v1.11.6...v2.0.0

Generated via:

rm -rf deps/node-inspect && curl -sSL "https://github.com/nodejs/node-inspect/archive/v1.11.6.tar.gz" | tar -xzvf - && mv node-inspect-* deps/node-inspect

The version number increase is somewhat arbitrary this time around. It's a CLI so "major version" is ill defined. Main reason for picking 2.0.0 was that the tool is no longer tested on node <12.

Checklist
  • make test-node-inspect passes
  • tests and/or benchmarks are included
  • commit message follows commit guidelines

@jkrems
deps: update node-inspect to v2.0.0
a2c70c0 
Highlights:

* Remove use of `process.binding` on modern node (@addaleax)
* Increase timeout for port checking (@yilmazdurmaz)
* Auto-resume on start when `NODE_INSPECT_RESUME_ON_START` is set (@dolsem)

Compare: nodejs/node-inspect@v1.11.6...v2.0.0
@jkrems jkrems added inspector Issues and PRs related to the V8 inspector protocol debugger labels May 17, 2020
@jkrems jkrems mentioned this pull request May 17, 2020
Closed
@jkrems jkrems marked this pull request as ready for review May 17, 2020 18:31
@jasnell
Copy link
Member

jasnell commented May 18, 2020

Rubber-stamp LGTM

@nodejs-github-bot
Copy link
Collaborator

CI: https://ci.nodejs.org/job/node-test-pull-request/31385/

@jkrems jkrems added the author ready PRs that have at least one approval, no pending requests for changes, and a CI started. label May 18, 2020
@nodejs-github-bot
Copy link
Collaborator

CI: https://ci.nodejs.org/job/node-test-pull-request/31421/

mmarchini
mmarchini approved these changes May 20, 2020
View reviewed changes
Copy link
Contributor

@mmarchini mmarchini left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

RSLGTM

addaleax pushed a commit that referenced this pull request May 20, 2020
@jkrems @addaleax
deps: update node-inspect to v2.0.0
6961c7f 
Highlights:

* Remove use of `process.binding` on modern node (@addaleax)
* Increase timeout for port checking (@yilmazdurmaz)
* Auto-resume on start when `NODE_INSPECT_RESUME_ON_START`
  is set (@dolsem)

Compare: nodejs/node-inspect@v1.11.6...v2.0.0

PR-URL: #33447
Reviewed-By: Anna Henningsen <[email protected]>
Reviewed-By: Matheus Marchini <[email protected]>
Reviewed-By: Ben Noordhuis <[email protected]>
@addaleax
Copy link
Member

Landed in 6961c7f

@addaleax addaleax closed this May 20, 2020
codebytere pushed a commit that referenced this pull request Jun 18, 2020
@jkrems @codebytere
deps: update node-inspect to v2.0.0
b0bce9b 
Highlights:

* Remove use of `process.binding` on modern node (@addaleax)
* Increase timeout for port checking (@yilmazdurmaz)
* Auto-resume on start when `NODE_INSPECT_RESUME_ON_START`
  is set (@dolsem)

Compare: nodejs/node-inspect@v1.11.6...v2.0.0

PR-URL: #33447
Reviewed-By: Anna Henningsen <[email protected]>
Reviewed-By: Matheus Marchini <[email protected]>
Reviewed-By: Ben Noordhuis <[email protected]>
@codebytere codebytere mentioned this pull request Jun 28, 2020
Merged
codebytere pushed a commit that referenced this pull request Jul 6, 2020
@jkrems @codebytere
deps: update node-inspect to v2.0.0
8803d7e 
Highlights:

* Remove use of `process.binding` on modern node (@addaleax)
* Increase timeout for port checking (@yilmazdurmaz)
* Auto-resume on start when `NODE_INSPECT_RESUME_ON_START`
  is set (@dolsem)

Compare: nodejs/node-inspect@v1.11.6...v2.0.0

PR-URL: #33447
Reviewed-By: Anna Henningsen <[email protected]>
Reviewed-By: Matheus Marchini <[email protected]>
Reviewed-By: Ben Noordhuis <[email protected]>
@codebytere codebytere mentioned this pull request Jul 13, 2020
Merged
codebytere added a commit that referenced this pull request Jul 13, 2020
@codebytere
2020-07-21, Version 12.18.3 'Erbium' (LTS)
7cb2263 
Notable changes:

deps:
  * V8: cherry-pick eec10a2fd8fa (Stephen Belanger) [#33778](#33778)
  * update node-inspect to v2.0.0 (Jan Krems) [#33447](#33447)
  * uvwasi: cherry-pick 9e75217 (Colin Ihrig) [#33521](#33521)

PR-URL: #34343
codebytere added a commit that referenced this pull request Jul 14, 2020
@codebytere
2020-07-21, Version 12.18.3 'Erbium' (LTS)
84ee826 
Notable changes:

deps:
  * V8: cherry-pick eec10a2fd8fa (Stephen Belanger) [#33778](#33778)
  * update node-inspect to v2.0.0 (Jan Krems) [#33447](#33447)
  * uvwasi: cherry-pick 9e75217 (Colin Ihrig) [#33521](#33521)

PR-URL: #34343
codebytere added a commit that referenced this pull request Jul 16, 2020
@codebytere
2020-07-21, Version 12.18.3 'Erbium' (LTS)
6816188 
Notable changes:

deps:
  * upgrade npm to 6.14.6 (claudiahdz) [#34246](#34246)
  * V8: cherry-pick eec10a2fd8fa (Stephen Belanger) [#33778](#33778)
  * update node-inspect to v2.0.0 (Jan Krems) [#33447](#33447)
  * uvwasi: cherry-pick 9e75217 (Colin Ihrig) [#33521](#33521)

PR-URL: #34343
codebytere added a commit that referenced this pull request Jul 17, 2020
@codebytere
2020-07-21, Version 12.18.3 'Erbium' (LTS)
dfd3661 
Notable changes:

deps:
  * upgrade npm to 6.14.6 (claudiahdz) [#34246](#34246)
  * V8: cherry-pick eec10a2fd8fa (Stephen Belanger) [#33778](#33778)
  * update node-inspect to v2.0.0 (Jan Krems) [#33447](#33447)
  * uvwasi: cherry-pick 9e75217 (Colin Ihrig) [#33521](#33521)

PR-URL: #34343
codebytere added a commit that referenced this pull request Jul 21, 2020
@codebytere
2020-07-21, Version 12.18.3 'Erbium' (LTS)
771fdd6 
Notable changes:

deps:
  * upgrade npm to 6.14.6 (claudiahdz) [#34246](#34246)
  * update node-inspect to v2.0.0 (Jan Krems) [#33447](#33447)
  * uvwasi: cherry-pick 9e75217 (Colin Ihrig) [#33521](#33521)

PR-URL: #34343
codebytere added a commit that referenced this pull request Jul 21, 2020
@codebytere
2020-07-22, Version 12.18.3 'Erbium' (LTS)
ca15f88 
Notable changes:

deps:
  * upgrade npm to 6.14.6 (claudiahdz) [#34246](#34246)
  * update node-inspect to v2.0.0 (Jan Krems) [#33447](#33447)
  * uvwasi: cherry-pick 9e75217 (Colin Ihrig) [#33521](#33521)

PR-URL: #34343
codebytere added a commit that referenced this pull request Jul 22, 2020
@codebytere
2020-07-22, Version 12.18.3 'Erbium' (LTS)
e3e0927 
Notable changes:

deps:
  * upgrade npm to 6.14.6 (claudiahdz) [#34246](#34246)
  * update node-inspect to v2.0.0 (Jan Krems) [#33447](#33447)
  * uvwasi: cherry-pick 9e75217 (Colin Ihrig) [#33521](#33521)

PR-URL: #34343
codebytere added a commit that referenced this pull request Jul 22, 2020
@codebytere
2020-07-22, Version 12.18.3 'Erbium' (LTS)
90ee98a 
Notable changes:

deps:
  * upgrade npm to 6.14.6 (claudiahdz) [#34246](#34246)
  * update node-inspect to v2.0.0 (Jan Krems) [#33447](#33447)
  * uvwasi: cherry-pick 9e75217 (Colin Ihrig) [#33521](#33521)

PR-URL: #34343
cjihrig pushed a commit that referenced this pull request Jul 23, 2020
@codebytere @cjihrig
2020-07-22, Version 12.18.3 'Erbium' (LTS)
b8245a6 
Notable changes:

deps:
  * upgrade npm to 6.14.6 (claudiahdz) [#34246](#34246)
  * update node-inspect to v2.0.0 (Jan Krems) [#33447](#33447)
  * uvwasi: cherry-pick 9e75217 (Colin Ihrig) [#33521](#33521)

PR-URL: #34343
Trott pushed a commit to Trott/io.js that referenced this pull request Apr 15, 2021
@jkrems @Trott
deps: update node-inspect to v2.0.0
b8dc43f 
Highlights:

* Remove use of `process.binding` on modern node (@addaleax)
* Increase timeout for port checking (@yilmazdurmaz)
* Auto-resume on start when `NODE_INSPECT_RESUME_ON_START`
  is set (@dolsem)

Compare: nodejs/node-inspect@v1.11.6...v2.0.0

PR-URL: nodejs#33447
Reviewed-By: Anna Henningsen <[email protected]>
Reviewed-By: Matheus Marchini <[email protected]>
Reviewed-By: Ben Noordhuis <[email protected]>
Trott pushed a commit to Trott/io.js that referenced this pull request Apr 15, 2021
@jkrems @Trott
deps: update node-inspect to v2.0.0
6035dfc 
Highlights:

* Remove use of `process.binding` on modern node (@addaleax)
* Increase timeout for port checking (@yilmazdurmaz)
* Auto-resume on start when `NODE_INSPECT_RESUME_ON_START`
  is set (@dolsem)

Compare: nodejs/node-inspect@v1.11.6...v2.0.0

PR-URL: nodejs#33447
Reviewed-By: Anna Henningsen <[email protected]>
Reviewed-By: Matheus Marchini <[email protected]>
Reviewed-By: Ben Noordhuis <[email protected]>
Trott pushed a commit to Trott/io.js that referenced this pull request Apr 15, 2021
@jkrems @Trott
deps: update node-inspect to v2.0.0
30f2945 
Highlights:

* Remove use of `process.binding` on modern node (@addaleax)
* Increase timeout for port checking (@yilmazdurmaz)
* Auto-resume on start when `NODE_INSPECT_RESUME_ON_START`
  is set (@dolsem)

Compare: nodejs/node-inspect@v1.11.6...v2.0.0

PR-URL: nodejs#33447
Reviewed-By: Anna Henningsen <[email protected]>
Reviewed-By: Matheus Marchini <[email protected]>
Reviewed-By: Ben Noordhuis <[email protected]>
Trott pushed a commit to Trott/io.js that referenced this pull request Apr 15, 2021
@jkrems @Trott
deps: update node-inspect to v2.0.0
2168f7b 
Highlights:

* Remove use of `process.binding` on modern node (@addaleax)
* Increase timeout for port checking (@yilmazdurmaz)
* Auto-resume on start when `NODE_INSPECT_RESUME_ON_START`
  is set (@dolsem)

Compare: nodejs/node-inspect@v1.11.6...v2.0.0

PR-URL: nodejs#33447
Reviewed-By: Anna Henningsen <[email protected]>
Reviewed-By: Matheus Marchini <[email protected]>
Reviewed-By: Ben Noordhuis <[email protected]>
Trott pushed a commit to Trott/io.js that referenced this pull request Apr 15, 2021
@jkrems @Trott
deps: update node-inspect to v2.0.0
d67c82c 
Highlights:

* Remove use of `process.binding` on modern node (@addaleax)
* Increase timeout for port checking (@yilmazdurmaz)
* Auto-resume on start when `NODE_INSPECT_RESUME_ON_START`
  is set (@dolsem)

Compare: nodejs/node-inspect@v1.11.6...v2.0.0

PR-URL: nodejs#33447
Reviewed-By: Anna Henningsen <[email protected]>
Reviewed-By: Matheus Marchini <[email protected]>
Reviewed-By: Ben Noordhuis <[email protected]>
Trott pushed a commit to Trott/io.js that referenced this pull request Apr 15, 2021
@jkrems @Trott
deps: update node-inspect to v2.0.0
4f894b1 
Highlights:

* Remove use of `process.binding` on modern node (@addaleax)
* Increase timeout for port checking (@yilmazdurmaz)
* Auto-resume on start when `NODE_INSPECT_RESUME_ON_START`
  is set (@dolsem)

Compare: nodejs/node-inspect@v1.11.6...v2.0.0

PR-URL: nodejs#33447
Reviewed-By: Anna Henningsen <[email protected]>
Reviewed-By: Matheus Marchini <[email protected]>
Reviewed-By: Ben Noordhuis <[email protected]>
Trott pushed a commit to Trott/io.js that referenced this pull request Apr 15, 2021
@jkrems @Trott
deps: update node-inspect to v2.0.0
36a08e7 
Highlights:

* Remove use of `process.binding` on modern node (@addaleax)
* Increase timeout for port checking (@yilmazdurmaz)
* Auto-resume on start when `NODE_INSPECT_RESUME_ON_START`
  is set (@dolsem)

Compare: nodejs/node-inspect@v1.11.6...v2.0.0

PR-URL: nodejs#33447
Reviewed-By: Anna Henningsen <[email protected]>
Reviewed-By: Matheus Marchini <[email protected]>
Reviewed-By: Ben Noordhuis <[email protected]>
Trott pushed a commit to Trott/io.js that referenced this pull request Apr 16, 2021
@jkrems @Trott
deps: update node-inspect to v2.0.0
2a35e62 
Highlights:

* Remove use of `process.binding` on modern node (@addaleax)
* Increase timeout for port checking (@yilmazdurmaz)
* Auto-resume on start when `NODE_INSPECT_RESUME_ON_START`
  is set (@dolsem)

Compare: nodejs/node-inspect@v1.11.6...v2.0.0

PR-URL: nodejs#33447
Reviewed-By: Anna Henningsen <[email protected]>
Reviewed-By: Matheus Marchini <[email protected]>
Reviewed-By: Ben Noordhuis <[email protected]>
Trott pushed a commit to Trott/io.js that referenced this pull request Apr 16, 2021
@jkrems @Trott
deps: update node-inspect to v2.0.0
3b9cf54 
Highlights:

* Remove use of `process.binding` on modern node (@addaleax)
* Increase timeout for port checking (@yilmazdurmaz)
* Auto-resume on start when `NODE_INSPECT_RESUME_ON_START`
  is set (@dolsem)

Compare: nodejs/node-inspect@v1.11.6...v2.0.0

PR-URL: nodejs#33447
Reviewed-By: Anna Henningsen <[email protected]>
Reviewed-By: Matheus Marchini <[email protected]>
Reviewed-By: Ben Noordhuis <[email protected]>
Trott pushed a commit to Trott/io.js that referenced this pull request Apr 16, 2021
@jkrems @Trott
deps: update node-inspect to v2.0.0
bb3afc5 
Highlights:

* Remove use of `process.binding` on modern node (@addaleax)
* Increase timeout for port checking (@yilmazdurmaz)
* Auto-resume on start when `NODE_INSPECT_RESUME_ON_START`
  is set (@dolsem)

Compare: nodejs/node-inspect@v1.11.6...v2.0.0

PR-URL: nodejs#33447
Reviewed-By: Anna Henningsen <[email protected]>
Reviewed-By: Matheus Marchini <[email protected]>
Reviewed-By: Ben Noordhuis <[email protected]>
Trott pushed a commit to Trott/io.js that referenced this pull request Apr 16, 2021
@jkrems @Trott
deps: update node-inspect to v2.0.0
9b71f9c 
Highlights:

* Remove use of `process.binding` on modern node (@addaleax)
* Increase timeout for port checking (@yilmazdurmaz)
* Auto-resume on start when `NODE_INSPECT_RESUME_ON_START`
  is set (@dolsem)

Compare: nodejs/node-inspect@v1.11.6...v2.0.0

PR-URL: nodejs#33447
Reviewed-By: Anna Henningsen <[email protected]>
Reviewed-By: Matheus Marchini <[email protected]>
Reviewed-By: Ben Noordhuis <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mmarchini mmarchini mmarchini approved these changes

@addaleax addaleax addaleax approved these changes

@bnoordhuis bnoordhuis bnoordhuis approved these changes

Assignees
No one assigned
Labels
author ready PRs that have at least one approval, no pending requests for changes, and a CI started. inspector Issues and PRs related to the V8 inspector protocol
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
6 participants
@jkrems @jasnell @nodejs-github-bot @addaleax @bnoordhuis @mmarchini